Skip to content

Conversation

@shuizhongyueming
Copy link

@shuizhongyueming shuizhongyueming commented Oct 17, 2023

Add a new option --proxy-cache to cache response from the proxy server and will auto decompress the response if it is compressed based on the content-encoding header

Contributor checklist
  • Provide tests for the changes (unless documentation-only)
  • Documented any new features, CLI switches, etc. (if applicable)
    • Server --help output
    • README.md
    • doc/http-server.1 (use the same format as other entries)
  • The pull request is being made against the master branch
Maintainer checklist
  • Assign a version triage tag
  • Approve tests if applicable

@github-actions
Copy link

This pull request has been inactive for 360 days

@github-actions github-actions bot added the stale label Nov 17, 2024
@KernelDeimos
Copy link
Contributor

After manually testing and reviewing this code I've come to understand that this is half a proxy implementation - it writes every proxied response to a file, overwriting the file if a proxied response already exists there. There is only one file so, effectively, this is just a local file that contains the last response and is not used by http-server when generating responses. Merging this as-is would introduce a performance overhead.

What is this flag meant to be used for?

@github-actions github-actions bot removed the stale label Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants