add xpu support in test_modeling_janus.py::JanusIntegrationTest::test… #41986
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_model_generate_images Signed-off-by: Wang, Yi A <[email protected]>
Contributor
Author
|
@ydshieh please help review |
Contributor
Author
|
The change in modeling is because: xpu set allow_is_causal_skip to True for prefill in static cache case for performance optimization in sdpa, as a result the attention_mask may not be contained in model_inputs. |
Contributor
Author
|
Intel XPU: @IlyasMoutawwakil |
Contributor
|
@sywangyi , pls fix CI issues, thx. |
ydshieh
approved these changes
Nov 6, 2025
Collaborator
ydshieh
left a comment
ydshieh
left a comment
There was a problem hiding this comment.
sound good, so it is kind of xpu specific, but general users might have use that flag too, so make sense.
Thank you. Please follow @yao-matrix to fix the failing tests. (about the modular files)
Signed-off-by: Wang, Yi A <[email protected]>
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: janus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_model_generate_images
add xpu support in tests/models/janus/test_modeling_janus.py::JanusIntegrationTest::test_model_generate_images