feat(kernels): add opt-out flag to disable kernels hub usage through the lib #41990
+138
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
mfuntowicz
force-pushed
the
kernels-opt-out-flag
branch
from
450ccab to
7c963b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to bring an opt-out mecanism to disable hub kernels (aka
kernels) globally throughtransformers.The default value for the
USE_HUB_KERNELSenvironment variable defaults toYESto maintain backward compatiblity with the current machinery.In more details, it works by proxying the
kernels.use_kernel_forward_from_hubmethod to include our_kernels_enabledbranching logic. In case of_kernels_enabled == False, the functionuse_kernel_forward_from_hubwill return an identity decorator which should just default to the current class the decorator is attached to.I added tests to a new folder
integrations.tests_hub_kernels.pyto match the layout structure of the sources folder.Let me know if it was not the correct way to do, will swizzle at the right place.