Fix Mixtral: Docstring uses consistent 'top_k_index' and 'top_k_weights' in MixtralSparseMoeBlock #42000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR resolves a minor documentation inconsistency found in the
MixtralSparseMoeBlock.forwardmethod located insrc/transformers/models/mixtral/modular_mixtral.py.The function definition correctly uses the parameters
top_k_indexandtop_k_weights, but the docstring incorrectly referenced them asselected_expertsandrouting_weights.This update ensures the documentation is accurate, which is crucial for code clarity and for any models that inherit this MoE block.
Fixes #41984
Before submitting
Who can review?
@ArthurZucker (As tagged in the original issue thread)