Skip to content

Conversation

@yaswanth19
Copy link
Contributor

@yaswanth19 yaswanth19 commented Nov 5, 2025

@yonigozlan What do you think of the logic change. I was working on another where I had (num_crops, 3,h,w) and the existing logic was breaking coz h,w are same but num_crops are diff. This one should be no different in most cases considering num channels is first dim.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: vitmatte

@yaswanth19
Copy link
Contributor Author

yaswanth19 commented Nov 5, 2025

@yonigozlan for review. Here _cast_tensor_to_float func was unused hence removed it

Copy link
Member

@yonigozlan yonigozlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's a need to change anything here. The case you described should be already supported by using is_nested=True in group_images_by_shape and reorder_images. It will flattened the batch_size and num_crops dimensions, then reconstruct them both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants