Compress #42643
Merged
Compress #42643
+27
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: compressed_tensors_integration |
Contributor
Author
|
run-slow: compressed_tensors_integration |
Contributor
Author
|
cc @yao-matrix |
Contributor
Author
|
Hi @ydshieh . Could you please review this PR? Thanks! |
ydshieh
reviewed
Dec 5, 2025
Comment on lines
+83
to
+85
| torch.equal( | ||
| submodule.weight.to(torch_device), comp_decomp_obj.weight.to(torch_device) | ||
| ), |
Collaborator
There was a problem hiding this comment.
You have seen that these 2 could be on different device?
Contributor
Author
There was a problem hiding this comment.
Yes, I run it on A100 and got the device error:
FAILED tests/quantization/compressed_tensors_integration/test_compressed_models.py::StackCompressedModelTest::test_compressed_uncompressed_model_shapes - RuntimeError: Expected all tensors to be on the same device, but got other is on cuda:1, different from other tensors on cuda:0 (wh...
Collaborator
MekkCyber
approved these changes
Dec 5, 2025
Contributor
MekkCyber
left a comment
MekkCyber
left a comment
There was a problem hiding this comment.
Sounds good! Thanks for fixing
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
Signed-off-by: jiqing-feng <[email protected]>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sarathc-cerebras
pushed a commit
to sarathc-cerebras/transformers
that referenced
this pull request
Dec 7, 2025
* fix compressed tensor tests Signed-off-by: jiqing-feng <[email protected]> * update Signed-off-by: jiqing-feng <[email protected]> * update comment Signed-off-by: jiqing-feng <[email protected]> * format Signed-off-by: jiqing-feng <[email protected]> --------- Signed-off-by: jiqing-feng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix xpu tests in compressed tensors by mapping different expect outputs.