Skip to content

Conversation

@f1234k
Copy link

@f1234k f1234k commented Nov 16, 2025

Describe your PR, what does it fix/add?

Add greek translation.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Nope.

Is it ready for merging, or does it need work?

Ready for merging.

@github-actions github-actions bot added the core label Nov 16, 2025
@f1234k f1234k changed the title Add greek translations i18n: Add greek translations Nov 17, 2025
@vaxerski
Copy link
Member

ai, please recheck

@github-actions
Copy link

AI translation check result:

Translation check not ok

  • TXT_KEY_PERMISSION_REQUEST_UNKNOWN (el_GR): starts with Latin "Mια" (ASCII M) instead of Greek "Μια".
  • TXT_KEY_PERMISSION_REQUEST_SCREENCOPY (el_GR): starts with Latin "Mια" (ASCII M) instead of Greek "Μια".
  • TXT_KEY_PERMISSION_REQUEST_PLUGIN (el_GR): starts with Latin "Mια" (ASCII M) instead of Greek "Μια".
  • TXT_KEY_PERMISSION_DENY (el_GR): "Aρνούμαι" starts with Latin "A" instead of Greek "Α" (and button label/form may be better as "Άρνηση").
  • TXT_KEY_NOTIF_FAILED_ASSETS (el_GR): uses incorrect word "πακετά" (nonsense/grammatically wrong). Needs a correct term (e.g. "πακέτου/παραλήπτη πακέτου/πακεταρίσματος" or "πακεταρίσματος της διανομής σας") and general grammar tuning.
  • TXT_KEY_NOTIF_INVALID_MONITOR_LAYOUT (el_GR): missing space due to literal concatenation ("... για" + "περισσότερα" -> "γιαπερισσότερα").
  • TXT_KEY_NOTIF_MONITOR_AUTO_SCALE (el_GR): "Μη έγκυρh" uses Latin 'h' instead of Greek 'η' and should be "Μη έγκυρη".
  • TXT_KEY_NOTIF_FAILED_TO_LOAD_PLUGIN (el_GR): left in English ("Failed to load plugin {name}: {error}") instead of Greek.

Please note this check is a guideline, not a hard requirement. It is here to help you translate. If you disagree with some points, just state that. Any typos should be fixed.

@f1234k
Copy link
Author

f1234k commented Nov 18, 2025

ai, please recheck

@vaxerski most of the issues mentioned by AI should be fixed now. The TXT_KEY_NOTIF_FAILED_ASSETS notification is bogus.

@vaxerski
Copy link
Member

okay, thanks!

@vaxerski
Copy link
Member

clang-format pls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants