Added 'includeSystem' parameter to loadAllGroups and related methods #683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikadamczyk
force-pushed
the
ct-group-is-system
branch
from
67cbdaa to
9356871
Compare
alongosz
reviewed
Nov 28, 2025
|
|
||
| try { | ||
| $defaultGroupsIterable = $contentTypeService->loadContentTypeGroups(); | ||
| $defaultGroups = is_array($defaultGroupsIterable) ? $defaultGroupsIterable : iterator_to_array($defaultGroupsIterable); |
Member
There was a problem hiding this comment.
AFAIR our polyfill iterator_to_array should be able to handle that for you.
| /** | ||
| * Test that system ContentTypeGroups are returned only when explicitly requested. | ||
| * | ||
| * @covers \Ibexa\Contracts\Core\Repository\ContentTypeService::loadContentTypeGroups() |
Member
There was a problem hiding this comment.
Please don't add @covers annotation to specific methods. We add it only for a class the top of a test case class. It makes coverage report somehow incomplete AFAIR.
Comment on lines
223
to
224
| ->with($this->equalTo(false)) | ||
| ->will($this->returnValue([])); |
Member
There was a problem hiding this comment.
This was legacy style.
Rather:
Suggested change
| ->with($this->equalTo(false)) | |
| ->will($this->returnValue([])); | |
| ->with(false) | |
| ->willReturnValue([]); |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
is_systemfilter when includeSystem=true; cache handler now maintains separate keys for lists with/without system groups and invalidates both on create/update/delete.For QA:
Documentation: