replace loading-shimmer and loading-text mixins with equivalent classes
#8928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelchadwick
requested review from
jrjohnson and
stopfstedt
as code owners
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
michaelchadwick
changed the title
loading-shimmer and loading-text mixins with equivalent classes
michaelchadwick
force-pushed
the
6615-replace-loading-shimmer-and-text-sass-mixins
branch
2 times, most recently
from
0fcddf7 to
6bd6bf5
Compare
stopfstedt
force-pushed
the
6615-replace-loading-shimmer-and-text-sass-mixins
branch
from
0d1c99a to
97ee6ec
Compare
this is kruft that snuck through in ilios#8930
this was blurring out the linked learner group titles in the curriculum report results, after the report has loaded.
stopfstedt
force-pushed
the
6615-replace-loading-shimmer-and-text-sass-mixins
branch
from
56c5b96 to
e23d2a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ilios/ilios#6615
Fixes ilios/ilios#6616
This replaces the
loading-shimmerandloading-textSASS mixins with equivalent classes and updates where they're used. The Courses loading needed an extra dose of the attributes found inloading-text.scssin order to override component styles.