Skip to content

Conversation

@Snowknight26
Copy link
Collaborator

Description

The text text wrapping in the Support & Feedback modal caused icons and text to not be aligned. Links are now a single column. Also removed element ids as they were duplicated and seemingly unused.

How Has This Been Tested?

  • Tested with/without third-party features at various breakpoints

Screenshots (if appropriate)

Before After
image image
image image

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

None

Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one also refactoring it to use a snippet. Thanks! :)

@github-actions
Copy link
Contributor

Deploying preview environment to https://pr-24018.preview.internal.immich.build/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants