bump to llvm20 #2332
Open
bump to llvm20 #2332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This introduces some new warnings, which is expected. |
Contributor
|
Nice! It will take me some time to review all the outstanding PR's, but this is great! |
Contributor
|
Works. Tested. Would be nice for this to be upstream, so that I can avoid recompilation of intermediate llvm19 stuff. |
Since C++23 std::unique_ptr<T> is constexpr See: https://en.cppreference.com/w/cpp/memory/unique_ptr.html
|
I think this needs a rebase- looks like C++23 changes are in here |
Contributor
|
Small merge conflict, please rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guess what? llvm 20 works with minor changes after updating to c++23. All tests are passing.
This PR relies on #2330.