Skip to content

Conversation

@vlastahajek
Copy link
Contributor

Updated Go to 1.24.9

  • fixed const format string errors

  • updated dependencies and generated code

  • I've read the contributing section of the project README.

@jdstrand jdstrand requested a review from devanbenz October 21, 2025 13:47
@jdstrand
Copy link
Contributor

@devanbenz - can you look at this? It's a bit different from your #26918

@vlastahajek
Copy link
Contributor Author

vlastahajek commented Oct 21, 2025

#26918 didn't update crossbuilder, which also needed regenerating code.

Also, don't like fixing formatting from fmt.Errorf(string(body) to fmt.Errorf("%s", string(body) where errors.New(string(body)) is better. The same for t.Errorf("%s", err.Error()) vs t.Error(err.Error()) or t.Fatalf("%s", err.Error()) vs t.Fatal(err.Error())

@devanbenz
Copy link

devanbenz commented Oct 21, 2025

#26918 didn't update crossbuilder, which also needed regenerating code.

Also, don't like fixing formatting from fmt.Errorf(string(body) to fmt.Errorf("%s", string(body) where errors.New(string(body)) is better. The same for t.Errorf("%s", err.Error()) vs t.Error(err.Error()) or t.Fatalf("%s", err.Error()) vs t.Fatal(err.Error())

I can do it without the formatting variant. I'll change my PR. I was thinking i'd rather change the parameters than the actual functions called. I'll modify tho to match this.

@vlastahajek vlastahajek force-pushed the chore/update_go_1.24.9 branch 3 times, most recently from 5f2c51f to 0b12fae Compare October 22, 2025 09:17
@vlastahajek vlastahajek force-pushed the chore/update_go_1.24.9 branch from 0b12fae to 3724166 Compare October 22, 2025 09:46
@philjb philjb added the 1.x label Oct 22, 2025
@vlastahajek
Copy link
Contributor Author

@jdstrand, can this be approved?

@jdstrand
Copy link
Contributor

@devanbenz - can you review this? I'd prefer if the golang updates for master-1.x, 1.12.x and 1.11.x were the same and since you are doing the master-1.x and 1.12.x branches, it would be good for you to take a look.

@jdstrand
Copy link
Contributor

@devanbenz - can you review this? I'd prefer if the golang updates for master-1.x, 1.12.x and 1.11.x were the same and since you are doing the master-1.x and 1.12.x branches, it would be good for you to take a look.

@devanbenz - ping

Copy link

@devanbenz devanbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just checked f60c5c4#diff-48b137054ce0c5bdde44cf6500433a0b90c2053eda8f5e67246d50d6d194fa37 and this appears to be nearly identical (except for a few errors in master-1.x that were already changed prior to this PR), thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants