-
Notifications
You must be signed in to change notification settings - Fork 3.7k
chore(1.11): Update Go to 1.24.9 #26921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.11
Are you sure you want to change the base?
Conversation
|
@devanbenz - can you look at this? It's a bit different from your #26918 |
|
#26918 didn't update crossbuilder, which also needed regenerating code. Also, don't like fixing formatting from |
I can do it without the formatting variant. I'll change my PR. I was thinking i'd rather change the parameters than the actual functions called. I'll modify tho to match this. |
5f2c51f to
0b12fae
Compare
0b12fae to
3724166
Compare
|
@jdstrand, can this be approved? |
|
@devanbenz - can you review this? I'd prefer if the golang updates for master-1.x, 1.12.x and 1.11.x were the same and since you are doing the master-1.x and 1.12.x branches, it would be good for you to take a look. |
@devanbenz - ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just checked f60c5c4#diff-48b137054ce0c5bdde44cf6500433a0b90c2053eda8f5e67246d50d6d194fa37 and this appears to be nearly identical (except for a few errors in master-1.x that were already changed prior to this PR), thank you!
Updated Go to 1.24.9
fixed const format string errors
updated dependencies and generated code
I've read the contributing section of the project README.