Skip to content

Conversation

@bnpfeife
Copy link
Contributor

@bnpfeife bnpfeife commented Oct 28, 2025

This is the 2.7 version of #26938.

$ dpkg -I influxdb2_2.x-4e0d22fc_amd64.deb
 new Debian package, version 2.0.
 size 39525512 bytes: control archive=2824 bytes.
      26 bytes,     1 lines      conffiles
     333 bytes,    12 lines      control
     621 bytes,     9 lines      md5sums
    5361 bytes,   198 lines   *  postinst             #!/bin/bash
    1475 bytes,    58 lines   *  postrm               #!/bin/bash
     428 bytes,    22 lines   *  preinst              #!/bin/bash
 Package: influxdb2
 Version: 2.x-4e0d22fc
 Architecture: amd64
 Maintainer: support <[email protected]>
 Installed-Size: 117721
 Depends: curl
 Recommends: influxdata-archive-keyring, influxdb2-cli
 Conflicts: influxdb
 Section: default
 Priority: optional
 Homepage: https://influxdata.com
 Description: Distributed time-series database.
$ rpm -q --recommends influxdb2-2.x-4e0d22fc.x86_64.rpm
influxdata-archive-keyring

@bnpfeife bnpfeife requested a review from jdstrand October 28, 2025 18:46
Copy link
Contributor

@jdstrand jdstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like with #26939, can you list that the recommends are doing what they should be?

Also, since this is significantly changing the packaging, can you show that the contents of the packages before and after this changes are the same (except the intended added recommends)? Thanks!

I think a member of the Edge team should review this. cc @devanbenz

@jdstrand jdstrand requested a review from devanbenz October 28, 2025 18:54
@bnpfeife bnpfeife self-assigned this Oct 28, 2025
@bnpfeife bnpfeife requested a review from jdstrand October 28, 2025 19:13
@jdstrand
Copy link
Contributor

Also, since this is significantly changing the packaging, can you show that the contents of the packages before and after this changes are the same (except the intended added recommends)? Thanks!

Can you also do this part? (want to see there are no file path changes comparing before and after)

@bnpfeife
Copy link
Contributor Author

Debian Package Differences

# dpkg -I influxdb2_2.x-4e0d22fc_amd64.deb >new
# dpkg -I influxdb2_2.x-afd04894_amd64.deb >old
$ diff <new> <old>
2c2
<  size 39525512 bytes: control archive=2824 bytes.
---
>  size 49345140 bytes: control archive=2853 bytes.
4,5c4,5
<      333 bytes,    12 lines      control
<      621 bytes,     9 lines      md5sums
---
>      327 bytes,    14 lines      control
>      605 bytes,     9 lines      md5sums
10c10,12
<  Version: 2.x-4e0d22fc
---
>  Version: 2.x-afd04894-1
>  License: MIT
>  Vendor: InfluxData
12,13c14,15
<  Maintainer: support <[email protected]>
<  Installed-Size: 117721
---
>  Maintainer: [email protected]
>  Installed-Size: 117691
15d16
<  Recommends: influxdata-archive-keyring, influxdb2-cli
16a18
>  Recommends: influxdb2-cli
``

```sh
# dpkg -I influxdb2_2.x-4e0d22fc_amd64.deb >new
# dpkg -I influxdb2_2.x-afd04894_amd64.deb >old
$ diff new old
16,17c16
< -rw-r--r-- root/root       152 ./usr/share/doc/influxdb2/changelog.Debian.gz
< -rw-r--r-- root/root         4 ./usr/share/doc/influxdb2/copyright
---
> -rw-r--r-- root/root       142 ./usr/share/doc/influxdb2/changelog.gz

@bnpfeife
Copy link
Contributor Author

bnpfeife commented Oct 28, 2025

Redhat Package Differences

# rpm -qip influxdb2-2.x-4e0d22fc.aarch64.rpm >new
# rpm -qip influxdb2-2.x_afd04894.aarch64.rpm >old
$ diff old new
2,3c2,3
< Version     : 2.x
< Release     : 4e0d22fc
---
> Version     : 2.x_afd04894
> Release     : 1
6c6
< Group       : Unspecified
---
> Group       : default
10,13c10,14
< Source RPM  : influxdb2-2.x-4e0d22fc.src.rpm
< Build Date  : Tue 28 Oct 2025 02:15:38 PM EDT
< Build Host  : 1b41e650c0c7
< Packager    : [email protected]
---
> Source RPM  : influxdb2-2.x_afd04894-1.src.rpm
> Build Date  : Mon 27 Oct 2025 08:56:55 PM EDT
> Build Host  : ip-10-0-116-47.ec2.internal
> Relocations : /
> Packager    : [email protected]
# rpm -qlvp influxdb2-2.x-4e0d22fc.aarch64.rpm >new
# rpm -qlvp influxdb2-2.x_afd04894.aarch64.rpm >old
$ diff new old
(identical)

@bnpfeife
Copy link
Contributor Author

bnpfeife commented Oct 28, 2025

Hey, @jdstrand I've added the package differences. For the file differences, I had to edit out the timestamps and sort them.

Copy link
Contributor

@jdstrand jdstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking on that. Looks like we added a copyright file to the deb, which is fine assuming that was intentional.

Copy link

@devanbenz devanbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants