chore: Migrate to go.kubebuilder.io/v4 and operator-sdk v1.41.1 #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konrad-ohms
force-pushed
the
ko-fix-bundle
branch
from
176882c to
177bf56
Compare
konrad-ohms
changed the title
konrad-ohms
commented
Sep 9, 2025
| | sed -e 's|\(image:[[:space:]]*\).*agent:latest|\1$(AGENT_IMG)|' \ | ||
| | $(OPERATOR_SDK) generate bundle -q --overwrite --version $(VERSION) $(BUNDLE_METADATA_OPTS) | ||
| ./hack/patch-bundle.sh | ||
| $(OPERATOR_MANIFEST_TOOLS) pinning pin ./bundle/manifests |
Contributor
Author
There was a problem hiding this comment.
This is a crucial change, otherwise the relatedImages section is missing in the clusterserviceversion and the promotion to red hat catalogs will fail.
konrad-ohms
commented
Sep 9, 2025
Comment on lines
-396
to
-400
| relatedImages: | ||
| - image: icr.io/instana/instana-agent-operator:0.0.0 | ||
| name: instana-agent-operator | ||
| - image: icr.io/instana/agent:latest | ||
| name: instana-agent |
Contributor
Author
There was a problem hiding this comment.
This section is no longer evaluated by the operator-sdk.
Instead operator-manifest-tools pinning pin ./bundle/manifests will read for any container image references found somewhere in the clusterserviceversion.yaml and will add them with digest to the relatedImages section.
The operator-sdk cannot be updated to latest, if we are still using go.kubebuilder.io/v3 in our project. I applied the manual migration steps as outlined here: https://book.kubebuilder.io/migration/manually_migration_guide_gov3_to_gov4#update-kustomize-manifests-with-the-changes-made-so-far With these changes, the relatedImages section is rendered correctly again in the olm bundle.
Newer operator-sdk versions will not automatically pin the digests in the ./bundle/manifests/instana-agent-operator.clusterserviceversion.yaml file. This is required in Red Hat certifications. We must run an additional tool call to add those information.
The new operator-manifest-tools will search for all image references automatically and pins them. It will not detect if tag and image name are split, therefore adding an annotation to refer to k8s_sensor and agent images. The relatedImages section seem no longer to be manually maintained in the yaml, therefore removing it. Also, removing the agent image annotation, as the operator-manifest-tools tool will detect the deployed image from the deployment automatically and will introduce duplicated images in the relatedImages section otherwise
konrad-ohms
force-pushed
the
ko-fix-bundle
branch
from
177bf56 to
bb66513
Compare
* ci: Fix e2e test image ref to deploy correct image The e2e logic deployed an incorrect image and therefore tested not the right image. * If make e2e fails set step as failure Signed-off-by: nagarajkandoor <[email protected]> --------- Signed-off-by: nagarajkandoor <[email protected]> Co-authored-by: nagarajkandoor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The operator-sdk cannot be updated to latest, if we are still using go.kubebuilder.io/v3 in our project.
I applied the manual migration steps as outlined here: https://book.kubebuilder.io/migration/manually_migration_guide_gov3_to_gov4#update-kustomize-manifests-with-the-changes-made-so-far
With these changes, the relatedImages section is rendered correctly again in the olm bundle.
What
References
Checklist
Note: Remember to run a helm chart release after the the operator release to make the changes available thru helm.