feat: support rspack #444
Merged
feat: support rspack #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
BobbieGoede
commented
Mar 8, 2025
| } | ||
| }, | ||
|
|
||
| loadInclude(id: string) { |
Member
Author
There was a problem hiding this comment.
This was necessary to make things work in rspack and probably improves performance for webpack, it seems like the plugin was handling more files than expected (such as css files as in the repro shared in #417 (comment))
kazupon
approved these changes
Mar 9, 2025
Member
kazupon
left a comment
kazupon
left a comment
There was a problem hiding this comment.
Awesome! ❤️
Thank you so much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for rspack is pretty much the same as it is for webpack, so I tried to reuse existing logic, also merged and reused the tests.
Hopefully resolves #417