fix: Opening local files without file:// #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andredestro
reviewed
Oct 6, 2025
OS-ruimoreiramendes
approved these changes
Oct 6, 2025
OS-ruimoreiramendes
left a comment
OS-ruimoreiramendes
left a comment
There was a problem hiding this comment.
I tested it the way you suggested. Before updating the xcframework, the issue was there, after updating to the new xcframework with the fix, I’m able to see both the PDF file and the video.
andredestro
approved these changes
Oct 6, 2025
This was referenced Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The methods to open local files expect a
file://URI, which is not guaranteed to happen (e.g. File Transfer returns a full file path withoutfile://).This PR fixes that by adding
file://to the local file path if it does not exist.Testing
Since there isn't an official release of this native library to test, you may use this capacitor application https://github.com/OS-pedrogustavobilro/issue-cap-file-viewer - and after doing
cap syncreplace theIONFileViewerLib.xcframeworkfound inios/App/Podswith the one from obtained from callingscripts/build_framework.shin this repo. You may test before replacing the xcframework (issue should occur, empty screen trying to open pdf / video), and after replacing xcframework (simple pdf is shown, sample video is played)