Skip to content

Conversation

@kumibrr
Copy link
Contributor

@kumibrr kumibrr commented Sep 23, 2025

Issue number: resolves #29929


What is the current behavior?

When forcing mode=ios in a collapsible header, .header-collapse-condense would still be applied from the header.md.scss file, leaving the collapsible header always hidden.

What is the new behavior?

When forcing mode=ios in a collapsible header, the .header-collapse-condense styles from the header.md.scss file won't be applied, and the collapsible header will be visible.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Something worth mentioning is that this behavior only appears after initial load: if the route is loaded refreshing the page, the header will appear and work correctly, but navigating forth and back will apply both the .ios and .md style files.

I showcase this with a modal because It'll always display the broken hehavior.

Before After
Screen.Recording.2025-09-23.at.20.00.26.mp4
Screen.Recording.2025-09-23.at.20.03.07.mp4

@kumibrr kumibrr requested a review from a team as a code owner September 23, 2025 18:07
@kumibrr kumibrr requested a review from gnbm September 23, 2025 18:07
@github-actions github-actions bot added the package: core @ionic/core package label Sep 23, 2025
@vercel
Copy link

vercel bot commented Sep 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ionic-framework Ready Ready Preview Comment Sep 29, 2025 4:44pm

@kumibrr kumibrr changed the title fix(header): ensure collapsible header is visible in iOS mode fix(header): collapsible header was hidden in iOS mode in non-ios devices Sep 24, 2025
@kumibrr kumibrr changed the title fix(header): collapsible header was hidden in iOS mode in non-ios devices fix(header): collapsible header was hidden on iOS mode in non-ios devices Oct 16, 2025
@ShaneK ShaneK changed the title fix(header): collapsible header was hidden on iOS mode in non-ios devices fix(header): show iOS condense header when app is in MD mode Dec 19, 2025
@vercel
Copy link

vercel bot commented Dec 19, 2025

@ShaneK is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

@ShaneK
Copy link
Member

ShaneK commented Dec 19, 2025

Hey @kumibrr! Thanks for this request! I hope you don't mind, I've modified your PR to remove the HTML file as we usually only use them for things that change a lot and we'll be checking on often. I've replaced it with a regression test that uses setContent instead, so we'll be alerted if this becomes a problem again in the future.

Hopefully we can get this merged and deployed soon. Thanks!

Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 🙂

@ShaneK ShaneK added this pull request to the merge queue Dec 22, 2025
Merged via the queue into ionic-team:main with commit f83b000 Dec 22, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Ionic mode detection on collapsible ion-header not working consistently

3 participants