- 
                Notifications
    
You must be signed in to change notification settings  - Fork 13.4k
 
fix(tabs): respect stencil lifecycle order for tab selection #30702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
      
        
          +45
        
        
          −29
        
        
          
        
      
    
  
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            11 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      d5d0774
              
                fix(tabs): respect stencil lifecycle order for tab selection
              
              
                ShaneK ab09149
              
                chore(): add updated snapshots
              
              
                Ionitron 5a56672
              
                fix(tab): handling edge cases
              
              
                ShaneK 6271be8
              
                Merge branch 'FW-6775' of github.com:ionic-team/ionic-framework into …
              
              
                ShaneK e5bedb8
              
                fix(): lint
              
              
                ShaneK eff5bc6
              
                chore(): add updated snapshots
              
              
                Ionitron 6230a24
              
                revering screenshots
              
              
                ShaneK fb63784
              
                merge
              
              
                ShaneK 052a65f
              
                Adding fallback for edge case
              
              
                ShaneK 8f5fc95
              
                chore(): add updated snapshots
              
              
                Ionitron 65fca78
              
                simplify
              
              
                ShaneK File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
        
          
  
    
      
          Binary file modified
          
            BIN
              
                -36 Bytes
                  (100%)
              
          
        
  ....e2e.ts-snapshots/tab-bar-translucent-container-ios-ltr-Mobile-Chrome-linux.png
  
  
      
      
   
        
      
      
    
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
        
          
  
    
      
          Binary file modified
          
            BIN
              
                -47 Bytes
                  (99%)
              
          
        
  ....e2e.ts-snapshots/tab-bar-translucent-container-ios-ltr-Mobile-Safari-linux.png
  
  
      
      
   
        
      
      
    | 
                       There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These screenshots are correct now. They were broken before, but I guess we didn't notice when we approved them. The first tab is selected per the code, so this was committed in the wrong state.  | 
            
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These screenshots are correct now. They were broken before, but I guess we didn't notice when we approved them. The first tab is selected per the code, so this was committed in the wrong state.