fix(tabs): select correct tab when routes have similar prefixes #30863
+337
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
package: vue
thetaPC
approved these changes
Dec 16, 2025
Contributor
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
LGTM, with minor suggestions
Co-authored-by: Maria Hutt <[email protected]>
brandyscarney
approved these changes
Dec 16, 2025
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Looks good - just some minor suggestions for the Vue test files!
packages/vue/test/base/src/views/tabs-similar-prefixes/Home.vue
Outdated
Show resolved
Hide resolved
packages/vue/test/base/src/views/tabs-similar-prefixes/Home2.vue
Outdated
Show resolved
Hide resolved
packages/vue/test/base/src/views/tabs-similar-prefixes/Home3.vue
Outdated
Show resolved
Hide resolved
packages/vue/test/base/src/views/tabs-similar-prefixes/TabsSimilarPrefixes.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: Brandy Smith <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30448
What is the current behavior?
When using ion-tabs with routes that share a common prefix (e.g.,
/home,/home2,/home3), navigating to/home2incorrectly highlights the/hometab. This occurs because the tab matching logic usespathname.startsWith(href), which causes/home2to match/homesince/home2starts with/home.What is the new behavior?
Tab selection now uses path segment matching instead of simple prefix matching. A tab's href will only match if the pathname is an exact match OR starts with the href followed by a / (for nested routes). This ensures /home2 no longer incorrectly matches /home, while still allowing /home/details to correctly match the /home tab.
Does this introduce a breaking change?
Other information
Current dev build: