-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
TEST: enable provide sweep by default #10955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
guillaumemichel
wants to merge
43
commits into
master
Choose a base branch
from
reprovide-sweep-enabled
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fd885d0 to
7c8e299
Compare
e1601f3 to
6be27cb
Compare
after conflict resolution, to confirm CI is still green
eb41d89 to
4076744
Compare
8e19bd1 to
e43ec5e
Compare
82e0c30 to
708bcb8
Compare
e8af19b to
6b9ee76
Compare
20f3ae9 to
1c914aa
Compare
1c914aa to
1eb61e0
Compare
1eb61e0 to
9575893
Compare
a9fbdd0 to
e9ed71f
Compare
gammazero
approved these changes
Oct 30, 2025
Depends on current state of unmerged kad-dht PRs combined: * libp2p/go-libp2p-kad-dht#1181 * libp2p/go-libp2p-kad-dht#1187 * libp2p/go-libp2p-kad-dht#1188 * libp2p/go-libp2p-kad-dht#1189 Combined at https://github.com/libp2p/go-libp2p-kad-dht/tree/provider/recent-changes-tmp (22a7685)
gammazero
approved these changes
Nov 1, 2025
| provider_reprovider_provide_count | ||
| provider_reprovider_reprovide_count | ||
| target_info | ||
| total_provide_count_total |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be better named, total_provide_count or provide_count_total?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test whether the provide sweep system passes all kubo tests when enabled by default.
Wider Context