test: add regression tests for config secrets protection #11061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds critical test coverage for security-sensitive config settings: Identity.PrivKey protection: - PrivKey concealed in `ipfs config show` - PrivKey cannot be read via `ipfs config Identity.PrivKey` or `ipfs config Identity` - PrivKey cannot be set via `ipfs config replace` - PrivKey preserved when re-injecting config without it TLS security validation: - AutoConf.TLSInsecureSkipVerify defaults to false (secure) - HTTPRetrieval.TLSInsecureSkipVerify defaults to false (secure) - both settings can be explicitly enabled when needed all tests pass (9/9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes the gap and adds extra test coverage for security-sensitive config settings:
Identity.PrivKey protection:
ipfs config showipfs config Identity.PrivKeyoripfs config Identityipfs config replaceTLS security validation:
No code changes, as all tests pass. This is just a precaution for future refactors.