STP: Fix node level STP protocol override setting #2821
Conversation
ipspace
left a comment
ipspace
left a comment
There was a problem hiding this comment.
I think this can be made much simpler. Also, isn't stp.protocol already copied into node data?
| Get the effective STP protocol for a node, following the hierarchy: | ||
| node-level override → topology-level → default 'stp' | ||
| """ | ||
| def get_effective_stp_protocol(node: Box, topology: Box) -> str: |
There was a problem hiding this comment.
We have "modules.get_effective_module_attribute" function to get this job done (assuming you need it)
Admittedly, you'd have to add "or 'stp'" at the end as it can return None.
There was a problem hiding this comment.
Yes, I remembered (I asked it for similar patterns and it found the vlan module with interface - link - node - topology hierarchy)
Obviously this was just a toy experiment - I highly recommend to look into Cursor, this project is well suited to AI supported coding
| features = devices.get_device_features(node,topology.defaults) | ||
|
|
||
| protocol = topology.get("stp.protocol","stp") | ||
| protocol = get_effective_stp_protocol(node,topology) |
There was a problem hiding this comment.
Wouldn't it be easier to make "stp.protocol" inheritable? Then it would be copied into the node automatically.
There was a problem hiding this comment.
AI found the missing copy:, will that do it?
I’ll look for the simpler way
2 participants
Fixes #2820