-
-
Notifications
You must be signed in to change notification settings - Fork 20
[DW-34] lazy load AnyBitmap & improve Tiff processing #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mee-ironsoftware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my feedback.
IronSoftware.Drawing/IronSoftware.Drawing.Common.Tests/UnitTests/AnyBitmapFunctionality.cs
Outdated
Show resolved
Hide resolved
mee-ironsoftware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another feedback for optimization loading Tiff image.
mee-ironsoftware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outstanding work! The implementations significantly improve IronSoftware.System.Drawing's performance, thread safety, and maintainability.
I have 2 minor suggestions below that are optional enhancements - you can safely ignore them and proceed with merge:
- Exception Types: Consider InvalidOperationException instead of generic Exception
- FrameCount Readability: Current pattern is clever, alternative shown if preferred
mee-ironsoftware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ikkyuland I just found 1 issue please check my feedback.
first-ironsoftware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great 🎉
Title
DW-34 lazy load AnyBitmap & improve Tiff processing
Description
Use PNG encoder to load image that bigger than 1902 * 1080 (dynamic in .net 6) //slower than BMP which use a lot more memoryFixes #(DW-34)
From This test

Type of change
Please select the relevant option by placing an 'x' inside the brackets, like this: [x].
How Has This Been Tested?
Describe the tests you ran to verify your changes. Provide instructions so others can reproduce the tests. Also, list any relevant details for your test configuration.
Checklist:
Please run through the checklist as much as possible and mark the items completed by placing an 'x' inside the brackets, like this: [x].
Additional Context
Add any other context, screenshots, or information about the pull request here.