-
Notifications
You must be signed in to change notification settings - Fork 102
Add support for hover, rename, document symbols. Compacted scoping for references and cleaner formatting. #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…r references and cleaner formatting.
|
you can |
isaacphi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!!
I've skimmed through it and I'll try it out as well. I appreciate your effort to make the outputs more useful, especially for large projects.
To be honest, as it stands, this codebase is a little shaky because different LSPs handle things wildly differently so I want to be careful with changes. Your PR comes at a good time because this repo has just moved up my priority list again.
|
For the future, if you submit smaller PRs with one feature each, I'll be able to merge them faster |
|
@isaacphi True, smaller PRs for sure would be much more manageable. A lot of cleanup to be done with better modularization of common patterns. I was aiming for something that I'm happy to use today myself :) That's why it's a bit sporadic and code quality is something to improve, though it compiles and does the job very well in a large projects. There is a simple python mcp client for testing without using actual Claude Code. For example you can build 2 binaries from your main and my branch and test them side by side. |
|
@orsenkucher sounds good! I'll check it out across a few other languages too. The development process is very cumbersome right now so I'm working on a test suite that runs on several LSPs and I'll check this out using that. |
|
I did some refactors to the codebase which meant it was easier for me to checkout some of the files from this branch into other branches instead of trying to deal with the conflicts here.
I'd still like to incorporate like your I'm also not sure I understand the difference in the I added integration tests with snapshots which make this repo a lot easier to develop for. You can take a look at Rust isn't my area of expertise so I'd appreciate any feedback you have based on your experience with this tool for large rust projects. Regardless, I'll close this PR for now. Thanks again for the contribution! |
|
@isaacphi That's great job! I will look into repos shortly |
Add incoming_calls and outgoing_calls tools
Added Language Server Tools and Improved Output Format
Improvements:
Format Enhancements: