Skip to content

fix: prevent numeric input from submitting forms #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
astagi merged 2 commits into from
Nov 7, 2025
Merged

fix: prevent numeric input from submitting forms #1209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ffd3fa
fix: prevent numeric input from submitting forms
edoardolincetto Oct 22, 2025
dcb012d
test: update snapshots after numeric input fix
edoardolincetto Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Input/Input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,10 +327,10 @@ export const Input = ({
ref={inputRef}
/>
<span className='input-group-text align-buttons flex-column'>
<button className='input-number-add' onClick={() => clickIncrDecr(1)}>
<button type='button' className='input-number-add' onClick={() => clickIncrDecr(1)}>
<span className='visually-hidden'>{incrementLabel || ''}</span>
</button>
<button className='input-number-sub' onClick={() => clickIncrDecr(-1)}>
<button type='button' className='input-number-sub' onClick={() => clickIncrDecr(-1)}>
<span className='visually-hidden'>{decrementLabel || ''}</span>
</button>
</span>
Expand Down
18 changes: 18 additions & 0 deletions test/__snapshots__/Storybook.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25163,6 +25163,7 @@ exports[`Stories Snapshots Documentazione/Form/Input EsempiDiCampiDiInput 1`] =
>
<button
class="input-number-add"
type="button"
>
<span
class="visually-hidden"
Expand All @@ -25172,6 +25173,7 @@ exports[`Stories Snapshots Documentazione/Form/Input EsempiDiCampiDiInput 1`] =
</button>
<button
class="input-number-sub"
type="button"
>
<span
class="visually-hidden"
Expand Down Expand Up @@ -25606,6 +25608,7 @@ exports[`Stories Snapshots Documentazione/Form/InputNumerico InputNumericoDimens
>
<button
class="input-number-add"
type="button"
>
<span
class="visually-hidden"
Expand All @@ -25615,6 +25618,7 @@ exports[`Stories Snapshots Documentazione/Form/InputNumerico InputNumericoDimens
</button>
<button
class="input-number-sub"
type="button"
>
<span
class="visually-hidden"
Expand Down Expand Up @@ -25655,6 +25659,7 @@ exports[`Stories Snapshots Documentazione/Form/InputNumerico InputNumericoDimens
>
<button
class="input-number-add"
type="button"
>
<span
class="visually-hidden"
Expand All @@ -25664,6 +25669,7 @@ exports[`Stories Snapshots Documentazione/Form/InputNumerico InputNumericoDimens
</button>
<button
class="input-number-sub"
type="button"
>
<span
class="visually-hidden"
Expand Down Expand Up @@ -25707,13 +25713,15 @@ exports[`Stories Snapshots Documentazione/Form/InputNumerico InputNumericoDisabi
>
<button
class="input-number-add"
type="button"
>
<span
class="visually-hidden"
/>
</button>
<button
class="input-number-sub"
type="button"
>
<span
class="visually-hidden"
Expand Down Expand Up @@ -25760,6 +25768,7 @@ exports[`Stories Snapshots Documentazione/Form/InputNumerico InputNumericoPercen
>
<button
class="input-number-add"
type="button"
>
<span
class="visually-hidden"
Expand All @@ -25769,6 +25778,7 @@ exports[`Stories Snapshots Documentazione/Form/InputNumerico InputNumericoPercen
</button>
<button
class="input-number-sub"
type="button"
>
<span
class="visually-hidden"
Expand Down Expand Up @@ -25813,6 +25823,7 @@ exports[`Stories Snapshots Documentazione/Form/InputNumerico InputNumericoRidime
>
<button
class="input-number-add"
type="button"
>
<span
class="visually-hidden"
Expand All @@ -25822,6 +25833,7 @@ exports[`Stories Snapshots Documentazione/Form/InputNumerico InputNumericoRidime
</button>
<button
class="input-number-sub"
type="button"
>
<span
class="visually-hidden"
Expand Down Expand Up @@ -25866,6 +25878,7 @@ exports[`Stories Snapshots Documentazione/Form/InputNumerico InputNumericoSteps
>
<button
class="input-number-add"
type="button"
>
<span
class="visually-hidden"
Expand All @@ -25875,6 +25888,7 @@ exports[`Stories Snapshots Documentazione/Form/InputNumerico InputNumericoSteps
</button>
<button
class="input-number-sub"
type="button"
>
<span
class="visually-hidden"
Expand Down Expand Up @@ -25924,6 +25938,7 @@ exports[`Stories Snapshots Documentazione/Form/InputNumerico InputNumericoValuta
>
<button
class="input-number-add"
type="button"
>
<span
class="visually-hidden"
Expand All @@ -25933,6 +25948,7 @@ exports[`Stories Snapshots Documentazione/Form/InputNumerico InputNumericoValuta
</button>
<button
class="input-number-sub"
type="button"
>
<span
class="visually-hidden"
Expand Down Expand Up @@ -28039,13 +28055,15 @@ exports[`Stories Snapshots Documentazione/Form/Validazione ValidazioneCompleta 1
>
<button
class="input-number-add"
type="button"
>
<span
class="visually-hidden"
/>
</button>
<button
class="input-number-sub"
type="button"
>
<span
class="visually-hidden"
Expand Down