Skip to content

Conversation

@mdwyer6
Copy link
Contributor

@mdwyer6 mdwyer6 commented Sep 8, 2025

Which problem is this PR solving?

Fixes two a11y issues. Logo/ home link in leftmost position in top bar does not show a focus ring. Additionally, the two menus have their own focus which is not actionable, this should be skipped since the menus' items are already focusable.

Description of the changes

  • Revert the outline css applied globally by ant design that breaks proper focus ring support on the Logo/home link
  • Manually set tabindex to -1 on both topbar menus so they are removed from taborder

How was this change tested?

  • Tabbed through the page to verify correct order

Checklist

@mdwyer6 mdwyer6 requested a review from a team as a code owner September 8, 2025 22:47
@mdwyer6 mdwyer6 requested review from albertteoh and removed request for a team September 8, 2025 22:47
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 8, 2025

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.14%. Comparing base (83cdac4) to head (45eb1c6).
⚠️ Report is 69 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3073   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files         257      257           
  Lines        8079     8079           
  Branches     2114     2114           
=======================================
  Hits         7929     7929           
  Misses        150      150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You may re-open it if you need more time.

@github-actions github-actions bot added the stale label Nov 10, 2025
@github-actions
Copy link

This pull request has been automatically closed due to inactivity. You may re-open it if you need more time. We really appreciate your contribution and we are sorry that this has not been completed.

@github-actions github-actions bot closed this Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant