[refactor]: use b.Loop() to simplify the code and improve performance (#7605)

<!--
!! Please DELETE this comment before posting.
We appreciate your contribution to the Jaeger project! 👋🎉
-->

## Which problem is this PR solving?
- <!-- Example: Resolves #123 -->

## Description of the changes

These changes use b.Loop() to simplify the code and improve performance
Supported by Go Team, more info: https://go.dev/blog/testing-b-loop


## How was this change tested?
- 

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

Signed-off-by: vastonus <[email protected]>

Author: vastonus

cmd/collector/app/queue/bounded_queue_test.go

@@ -325,7 +325,7 @@ func BenchmarkBoundedQueue(b *testing.B) {
 	q.StartConsumers(10, func( /* item */ any) {})
 	defer q.Stop()
 
-	for n := 0; n < b.N; n++ {
+	for n := 0; b.Loop(); n++ {
 		q.Produce(n)
 	}
 }
@@ -338,7 +338,7 @@ func BenchmarkBoundedQueueWithFactory(b *testing.B) {
 	})
 	defer q.Stop()
 
-	for n := 0; n < b.N; n++ {
+	for n := 0; b.Loop(); n++ {
 		q.Produce(n)
 	}
 }

cmd/ingester/app/consumer/offset/concurrent_list_test.go

@@ -139,7 +139,7 @@ func extractMin(arr []int64) (int64, []int64) {
 // BenchmarkInserts-8   	100000000	        70.6 ns/op	      49 B/op	       0 allocs/op
 func BenchmarkInserts(b *testing.B) {
 	l := newConcurrentList(0)
-	for i := 1; i < b.N; i++ {
+	for i := 1; b.Loop(); i++ {
 		l.insert(int64(i))
 	}
 }

internal/gogocodec/codec_test.go

@@ -92,9 +92,7 @@ func BenchmarkCodecUnmarshal25Spans(b *testing.B) {
 	bytes, err := c.Marshal(&trace)
 	require.NoError(b, err)
 
-	b.ResetTimer()
-
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		var trace model.Trace
 		err := c.Unmarshal(bytes, &trace)
 		require.NoError(b, err)

internal/storage/v1/api/spanstore/downsampling_writer_benchmark_test.go

@@ -28,9 +28,9 @@ func BenchmarkDownSamplingWriter_WriteSpan(b *testing.B) {
 		Ratio:    0.5,
 		HashSalt: "jaeger-test",
 	})
-	b.ResetTimer()
+
 	b.ReportAllocs()
-	for it := 0; it < b.N; it++ {
+	for b.Loop() {
 		c.WriteSpan(context.Background(), span)
 	}
 }
@@ -46,10 +46,10 @@ func BenchmarkDownSamplingWriter_HashBytes(b *testing.B) {
 	for i := 0; i < 16; i++ {
 		ba[i] = byte(i)
 	}
-	b.ResetTimer()
+
 	b.ReportAllocs()
 	h := c.sampler.hasherPool.Get().(*hasher)
-	for it := 0; it < b.N; it++ {
+	for b.Loop() {
 		h.hashBytes()
 	}
 	c.sampler.hasherPool.Put(h)
@@ -66,7 +66,7 @@ func BenchmarkDownsamplingWriter_RandomHash(b *testing.B) {
 	}
 	c := NewDownsamplingWriter(&noopWriteSpanStore{}, downsamplingOptions)
 	h := c.sampler.hasherPool.Get().(*hasher)
-	for it := 0; it < b.N; it++ {
+	for b.Loop() {
 		countSmallerThanRatio = 0
 		for i := 0; i < numberActions; i++ {
 			low := rand.Uint64()

internal/storage/v2/elasticsearch/tracestore/from_dbmodel_test.go

@@ -882,8 +882,8 @@ func BenchmarkProtoBatchToInternalTraces(b *testing.B) {
 	err = json.Unmarshal(data, &dbSpan)
 	require.NoError(b, err)
 	jb := []dbmodel.Span{dbSpan}
-	b.ResetTimer()
-	for n := 0; n < b.N; n++ {
+
+	for b.Loop() {
 		_, err := FromDBModel(jb)
 		assert.NoError(b, err)
 	}

internal/storage/v2/elasticsearch/tracestore/to_dbmodel_test.go

@@ -729,8 +729,7 @@ func BenchmarkInternalTracesToDbSpans(b *testing.B) {
 	td, err := unmarshaller.UnmarshalTraces(data)
 	require.NoError(b, err)
 
-	b.ResetTimer()
-	for n := 0; n < b.N; n++ {
+	for b.Loop() {
 		batches := ToDBModel(td)
 		assert.NotEmpty(b, batches)
 	}