fix: [ci]: Metrics comparison is flaky #7618
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| metricFamilies := []*io_prometheus_client.MetricFamily{mfWithNamespace, mfWithoutNamespace} | ||
|
|
||
| // Act: Call the normalization function. | ||
| normalizedFamilies := NormalizeMetricFamiliesForE2E(metricFamilies) |
There was a problem hiding this comment.
Function name mismatch: The test calls NormalizeMetricFamiliesForE2E (plural "Families") but the actual function is named NormalizeMetricFamilyForE2E (singular "Family"). This will cause a compilation error.
// Fix: Change to match the actual function name
NormalizeMetricFamilyForE2E(metricFamilies)
Suggested change
| normalizedFamilies := NormalizeMetricFamiliesForE2E(metricFamilies) | |
| normalizedFamilies := NormalizeMetricFamilyForE2E(metricFamilies) |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
| assert.Equal(t, 123.0, *metric1.Counter.Value, "Counter value should be unchanged") | ||
| expectedLabels1 := map[string]string{ | ||
| "service": "driver", | ||
| "namespace": E2EStableNamespace, |
There was a problem hiding this comment.
Constant name mismatch: The test references E2EStableNamespace (exported, capitalized) but the constant defined in normalizer.go is e2eStableNamespace (unexported, lowercase). This will cause a compilation error.
// Fix: Either use the correct constant name or export it
"namespace": "e2e-namespace-stable", // Use the string literal directly
// OR export the constant in normalizer.go as E2EStableNamespaceSpotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #7617
Issue: [ci]: Metrics comparison is flaky
Changes:
examples/hotrod/pkg/tracing/rpcmetrics/normalizer.go,examples/hotrod/pkg/tracing/rpcmetrics/normalizer_test.goPlease review carefully before merging.