[clickhouse] Add Attributes For Scope #7619

mahadzaryab1 · 2025-10-25T20:02:40Z

Which problem is this PR solving?

Towards [clickhouse] Implement Trace Reader For ClickHouse Storage #7134 and [clickhouse] Implement Trace Writer (Exporter) For ClickHouse Storage #7135

Description of the changes

This PR adds attributes for scopes to ClickHouse storage

How was this change tested?

CI and Unit tests

Checklist

I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
I have signed all commits
I have added unit tests for the new functionality
I have run lint and test steps successfully
- for jaeger: make lint test
- for jaeger-ui: npm run lint and npm run test

Signed-off-by: Mahad Zaryab <[email protected]>

codecov · 2025-10-25T20:14:04Z

Codecov Report

❌ Patch coverage is 84.37500% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.57%. Comparing base (6958a96) to head (6a83c90).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...torage/v2/clickhouse/tracestore/dbmodel/spanrow.go	0.00%	10 Missing ⚠️

❌ Your patch status has failed because the patch coverage (84.37%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7619      +/-   ##
==========================================
- Coverage   96.63%   96.57%   -0.06%     
==========================================
  Files         384      384              
  Lines       19385    19404      +19     
==========================================
+ Hits        18733    18740       +7     
- Misses        468      479      +11     
- Partials      184      185       +1

Flag	Coverage Δ
badger_v1	`8.83% <ø> (ø)`
badger_v2	`1.74% <0.00%> (-0.01%)`	⬇️
cassandra-4.x-v1-manual	`12.56% <ø> (ø)`
cassandra-4.x-v2-auto	`1.73% <0.00%> (-0.01%)`	⬇️
cassandra-4.x-v2-manual	`1.73% <0.00%> (-0.01%)`	⬇️
cassandra-5.x-v1-manual	`12.56% <ø> (ø)`
cassandra-5.x-v2-auto	`1.73% <0.00%> (-0.01%)`	⬇️
cassandra-5.x-v2-manual	`1.73% <0.00%> (-0.01%)`	⬇️
clickhouse	`1.66% <0.00%> (-0.01%)`	⬇️
elasticsearch-6.x-v1	`16.77% <ø> (ø)`
elasticsearch-7.x-v1	`16.80% <ø> (ø)`
elasticsearch-8.x-v1	`16.94% <ø> (ø)`
elasticsearch-8.x-v2	`1.74% <0.00%> (-0.01%)`	⬇️
elasticsearch-9.x-v2	`1.74% <0.00%> (-0.01%)`	⬇️
grpc_v1	`10.76% <ø> (ø)`
grpc_v2	`1.74% <0.00%> (-0.01%)`	⬇️
kafka-3.x-v1	`10.26% <ø> (ø)`
kafka-3.x-v2	`1.74% <0.00%> (-0.01%)`	⬇️
memory_v2	`1.74% <0.00%> (-0.01%)`	⬇️
opensearch-1.x-v1	`16.84% <ø> (ø)`
opensearch-2.x-v1	`16.84% <ø> (ø)`
opensearch-2.x-v2	`1.74% <0.00%> (-0.01%)`	⬇️
opensearch-3.x-v2	`1.74% <0.00%> (-0.01%)`	⬇️
query	`1.74% <0.00%> (-0.01%)`	⬇️
tailsampling-processor	`0.50% <0.00%> (-0.01%)`	⬇️
unittests	`95.48% <84.37%> (-0.06%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

internal/storage/v2/clickhouse/tracestore/dbmodel/from.go

Signed-off-by: Mahad Zaryab <[email protected]>

github-actions · 2025-10-26T01:19:12Z

Metrics Comparison Summary

Total changes across all snapshots: 53

Detailed changes per snapshot

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

Total Changes: 53

🆕 Added: 0 metrics
❌ Removed: 53 metrics
🔄 Modified: 0 metrics

❌ Removed Metrics

http_server_request_body_size_bytes (18 variants)

View diff sample

-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

- `http_server_request_duration_seconds` (17 variants)

View diff sample

-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.005",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.01",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.025",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.05",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.075",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.1",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

- `http_server_response_body_size_bytes` (18 variants)

View diff sample

-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

➡️ View full metrics file

yurishkuro · 2025-10-26T01:36:22Z

internal/storage/v2/clickhouse/tracestore/dbmodel/from.go

 		event.SetTimestamp(pcommon.NewTimestampFromTime(sr.EventTimestamps[i]))
 		putAttributes(
 			event.Attributes(),
+			&Attributes{


I'd add putAttributes2D helper for this

@yurishkuro done

Signed-off-by: Mahad Zaryab <[email protected]>

mahadzaryab1 added 7 commits October 25, 2025 15:35

Add Scope Attributes To Schema Creation Script

1340860

Signed-off-by: Mahad Zaryab <[email protected]>

Update Queries

eb85fa3

Signed-off-by: Mahad Zaryab <[email protected]>

Add ScopeAttributes To SpanRow

5c817db

Signed-off-by: Mahad Zaryab <[email protected]>

Add Scope Attributes To Writer

5192cb5

Signed-off-by: Mahad Zaryab <[email protected]>

Update Translation Layer

4da2390

Signed-off-by: Mahad Zaryab <[email protected]>

Fix Tests

4512b04

Signed-off-by: Mahad Zaryab <[email protected]>

Update Fixture

a5081a8

Signed-off-by: Mahad Zaryab <[email protected]>

mahadzaryab1 requested a review from yurishkuro October 25, 2025 20:02

mahadzaryab1 requested a review from a team as a code owner October 25, 2025 20:02

mahadzaryab1 added the changelog:exprimental Change to an experimental part of the code label Oct 25, 2025

dosubot bot added area/storage v2 labels Oct 25, 2025

Update Test

af80753

Signed-off-by: Mahad Zaryab <[email protected]>

yurishkuro reviewed Oct 25, 2025

View reviewed changes

internal/storage/v2/clickhouse/tracestore/dbmodel/from.go Show resolved Hide resolved

mahadzaryab1 requested a review from yurishkuro October 26, 2025 00:56

Address Feedback

12045f3

Signed-off-by: Mahad Zaryab <[email protected]>

yurishkuro reviewed Oct 26, 2025

View reviewed changes

Feedback

6a83c90

Signed-off-by: Mahad Zaryab <[email protected]>

mahadzaryab1 requested a review from yurishkuro October 26, 2025 01:48

yurishkuro approved these changes Oct 26, 2025

View reviewed changes

yurishkuro merged commit 65a8abf into jaegertracing:main Oct 26, 2025
65 of 66 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[clickhouse] Add Attributes For Scope #7619

[clickhouse] Add Attributes For Scope #7619

Uh oh!

mahadzaryab1 commented Oct 25, 2025

Uh oh!

codecov bot commented Oct 25, 2025 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Oct 26, 2025 •

edited

Loading

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

❌ Removed Metrics

Uh oh!

yurishkuro Oct 26, 2025

Uh oh!

mahadzaryab1 Oct 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[clickhouse] Add Attributes For Scope #7619

[clickhouse] Add Attributes For Scope #7619

Uh oh!

Conversation

mahadzaryab1 commented Oct 25, 2025

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

Uh oh!

codecov bot commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

github-actions bot commented Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Metrics Comparison Summary

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

❌ Removed Metrics

Uh oh!

yurishkuro Oct 26, 2025

Choose a reason for hiding this comment

Uh oh!

mahadzaryab1 Oct 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Oct 25, 2025 •

edited

Loading

github-actions bot commented Oct 26, 2025 •

edited

Loading