Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion django_redis/cache.py
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ def lock(self, *args, **kwargs):

@omit_exception
def close(self, **kwargs):
self.client.close(**kwargs)
self.client.close()

@omit_exception
def touch(self, *args, **kwargs):
Expand Down
12 changes: 12 additions & 0 deletions tests/test_backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -1029,3 +1029,15 @@ def test_sunionstore(self, cache: RedisCache):
cache.sadd("foo2", "bar2", "bar3")
assert cache.sunionstore("foo3", "foo1", "foo2") == 3
assert cache.smembers("foo3") == {"bar1", "bar2", "bar3"}

def test_close_with_signal_parameter(self, cache: RedisCache):
"""Test that close() method handles signal parameter from Django request_finished signal."""
# This should not raise TypeError even when called with extra parameters
# that Django's request_finished signal passes
cache.close(signal="request_finished", sender=object)

# Test with no parameters as well
cache.close()

# Test with arbitrary keyword arguments
cache.close(foo="bar", signal=None, sender="test")