Refactor process.cwd calls
#382
Open
+167
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lishaduck
force-pushed
the
big-refactor-pt-3.1
branch
2 times, most recently
from
95db8e3 to
9735acc
Compare
lishaduck
force-pushed
the
big-refactor-pt-3.1
branch
from
9735acc to
653ce91
Compare
I do think it'd be good to audit usages of cwd at some point. A few of these feel like they don't actually need the cwd. This is good bandaid for now though.
lishaduck
force-pushed
the
big-refactor-pt-3.1
branch
from
653ce91 to
bc0c45b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do think it'd be good to audit usages of cwd at some point.
A few of these feel like they don't actually need the cwd.
This is good bandaid for now though.