Migrate modules/statistics/RTPStatsCollector.ts
#2863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your contribution! |
jallamsetty1
requested changes
Jul 29, 2025
| */ | ||
| setLoss(loss) { | ||
| this.loss = loss || {}; | ||
| setLoss(loss: ILoss | undefined): void { |
Member
There was a problem hiding this comment.
I don't see undefined being passed to this function. You should be able to drop undefined here and also drop default value assignment in the next line.
| */ | ||
| setResolution(resolution) { | ||
| this.resolution = resolution || {}; | ||
| setResolution(resolution?: IResolution): void { |
| setEncodeStats(encodeStats) { | ||
| this.encodeStats = encodeStats || {}; | ||
| setEncodeStats(encodeStats?: Map<number, IEncodeStats>): void { | ||
| this.encodeStats = encodeStats || undefined; |
Member
There was a problem hiding this comment.
Ditto, lets make the parameter mandatory.
Member
|
Jenkins test this please. |
naman9271
force-pushed
the
RTCStatsCollector
branch
2 times, most recently
from
d7494e1 to
314f6a3
Compare
Member
|
Jenkins test this please. |
naman9271
force-pushed
the
RTCStatsCollector
branch
from
4f71c61 to
73355d1
Compare
Contributor
Author
|
changes dine and rebased please take a look |
Member
|
Jenkins test this please. |
naman9271
force-pushed
the
RTCStatsCollector
branch
from
73355d1 to
bc8dce4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.