feat: Polls using component. #2916
Conversation
| * @param question | ||
| * @param answers | ||
| */ | ||
| createPoll(pollId: string, question: string, answers: Array<{ name: string; }>) { |
There was a problem hiding this comment.
Why not use an array of stringas at this level, rather than have to flatten it here?
There was a problem hiding this comment.
So we can put it as a type ... I will drop the flattened strings from everywhere so we can have a single strucutre as it now differs and depends on the operation
There was a problem hiding this comment.
I forgot where we landed on this one, can you remind me pl?
damencho
force-pushed
the
polls-update
branch
from
7636744 to
ad4f29b
Compare
modules/xmpp/ChatRoom.ts
Outdated
| const msg = $msg({ to: targetJid, | ||
| type: 'chat' }); | ||
| // when not sending to a direct jid, let's indicate the room jid (used in polls) | ||
| const roomJid = useDirectJid ? this.roomjid : undefined; |
There was a problem hiding this comment.
Why is this needed? Isn't the room JID already in the to?
There was a problem hiding this comment.
Nope, we switched to sending messages to a component and the jid is missing there, it used to be the to of the messages.
There was a problem hiding this comment.
Yes, but we can get the target room with:
-- get room name with tenant and find room
local room = get_room_by_name_and_subdomain(session.jitsi_web_query_room, session.jitsi_web_query_prefix);
In Prosody, like we do for breakout rooms, no?
| * @param question | ||
| * @param answers | ||
| */ | ||
| createPoll(pollId: string, question: string, answers: Array<{ name: string; }>) { |
There was a problem hiding this comment.
I forgot where we landed on this one, can you remind me pl?
|
In the code where it is not voting, the answer is always in a structure with a name, greatly simplifies logic and types. |
modules/xmpp/ChatRoom.ts
Outdated
| const msg = $msg({ to: targetJid, | ||
| type: 'chat' }); | ||
| // when not sending to a direct jid, let's indicate the room jid (used in polls) | ||
| const roomJid = useDirectJid ? this.roomjid : undefined; |
There was a problem hiding this comment.
Yes, but we can get the target room with:
-- get room name with tenant and find room
local room = get_room_by_name_and_subdomain(session.jitsi_web_query_room, session.jitsi_web_query_prefix);
In Prosody, like we do for breakout rooms, no?
damencho
force-pushed
the
polls-update
branch
from
2576f48 to
d6efed3
Compare
damencho
force-pushed
the
polls-update
branch
from
ba93426 to
a7118f7
Compare
No description provided.