feat(chart): add configurable probe settings to replace hardcoded values #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@jmcgrath207 am I missing something you needed to review/merge this? |
added 2 commits
December 1, 2025 08:33
- Add /health endpoint for lightweight readiness checks - Add timeout to WaitGroup wait to prevent deadlock in getMetrics() - Update readiness probe to use /health instead of /metrics - Increase readiness probe timeout from 1s to 2s - Fix linting issue: use time.Since() instead of time.Now().Sub() - Add proper error handling for HTTP write operations Fixes readiness probe failures that occurred without logging errors. The /health endpoint responds immediately, preventing false failures when metrics collection is still initializing.
…ictPodByName function
Owner
Sorry about that, @Bak3y, as I was on hiatus on this project. I approve your PR for testing. |
Owner
|
@Bak3y Looks good and it's passing the e2e test, but I would like to see this change broken up for the recent commit of the dead lock issue you found. If you have the logs available please add those as well. - Add /health endpoint for lightweight readiness checks
- Add timeout to WaitGroup wait to prevent deadlock in getMetrics()
- Update readiness probe to use /health instead of /metrics
- Increase readiness probe timeout from 1s to 2s
- Fix linting issue: use time.Since() instead of time.Now().Sub()
- Add proper error handling for HTTP write operations
Fixes readiness probe failures that occurred without logging errors.
The /health endpoint responds immediately, preventing false failures
when metrics collection is still initializing.After that is cherry-picked away, I can merge and release this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166
This PR makes probe settings configurable by:
The hardcoded
timeoutSeconds: 1for readiness probes can now be configured based on deployment requirements.