Skip to content

Fix is_empty when error thrown while adding constraint #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
odow merged 2 commits into from
Oct 31, 2025
Merged

Fix is_empty when error thrown while adding constraint #371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03d96cd
Fix is_empty when error thrown while adding constraint
odow Oct 31, 2025
edadfff
Update
odow Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions ext/KNITROMathOptInterfaceExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,15 +185,24 @@ function MOI.empty!(model::Optimizer)
return
end

function _num_cons(model)
p = Ref{Cint}(0)
KNITRO.KN_get_number_cons(model, p)
return p[]
end

function MOI.is_empty(model::Optimizer)
return isempty(model.variable_info) &&
model.number_solved == 0 &&
!model.nlp_loaded &&
model.nlp_data === nothing &&
MOI.is_empty(model.nlp_model) &&
isempty(model.nlp_index_cons) &&
model.sense == MOI.FEASIBILITY_SENSE &&
model.number_solved == 0 &&
model.objective === nothing &&
isempty(model.constraint_mapping) &&
isempty(model.vector_nonlinear_oracle_constraints) &&
!model.nlp_loaded
_num_cons(model) == 0
end

function _throw_if_solved(model::Optimizer, attr::MOI.AbstractModelAttribute)
Expand Down
16 changes: 16 additions & 0 deletions test/MOI_wrapper.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,22 @@ function test_vector_nonlinear_oracle()
return
end

function test_issue_370()
model = KNITRO.Optimizer()
MOI.empty!(model)
f = MOI.VectorAffineFunction(MOI.VectorAffineTerm{Float64}[], [1.0, 2.0])
try
MOI.add_constraint(model, f, MOI.SecondOrderCone(2))
catch
end
@test !MOI.is_empty(model)
MOI.empty!(model)
@test MOI.is_empty(model)
x = MOI.add_variable(model)
@test MOI.get(model, MOI.NumberOfVariables()) == 1
return
end

end

TestMOIWrapper.runtests()
Loading