Skip to content

Fix neutral_element for AbstractArrays #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
odow merged 2 commits into from
Jan 14, 2025
Merged

Fix neutral_element for AbstractArrays #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b598bd7
Fix neutral_element for AbstractArrays
odow Jan 13, 2025
ecdd5c5
Add tests
odow Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/reduce.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ reduce_op(op::AddSubMul) = add_sub_op(op)

reduce_op(::typeof(add_dot)) = +

neutral_element(::typeof(+), T::Type) = zero(T)
neutral_element(::typeof(+), ::Type{T}) where {T} = zero(T)
neutral_element(::typeof(+), ::Type{T}) where {T<:AbstractArray} = Zero()

map_op(::AddSubMul) = *

Expand Down
18 changes: 18 additions & 0 deletions test/interface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,3 +215,21 @@ end
@test ret == reshape([3.0], 1, 1)
@test y == reshape([1.0], 1, 1, 1)
end

@testset "issue_318_neutral_element" begin
a = rand(3)
A = [rand(2, 2) for _ in 1:3]
@test_throws DimensionMismatch MA.operate(LinearAlgebra.dot, a, A)
y = a' * A
@test isapprox(MA.fused_map_reduce(MA.add_mul, a', A), y)
z = MA.operate(LinearAlgebra.dot, Int[], Int[])
@test iszero(z) && z isa Int
z = MA.operate(LinearAlgebra.dot, BigInt[], Int[])
@test iszero(z) && z isa BigInt
z = MA.operate(LinearAlgebra.dot, Int[], Float64[])
@test iszero(z) && z isa Float64
z = MA.operate(LinearAlgebra.dot, Matrix{Int}[], Matrix{Float64}[])
@test iszero(z) && z isa Float64
@test MA.fused_map_reduce(MA.add_mul, Matrix{Int}[], Float64[]) isa MA.Zero
@test MA.fused_map_reduce(MA.add_mul, Float64[], Matrix{Int}[]) isa MA.Zero
end
Loading