Skip to content

Conversation

@sanmai
Copy link
Collaborator

@sanmai sanmai commented May 31, 2025

No description provided.

@sanmai sanmai merged commit 772eb39 into kalimatas:master May 31, 2025
7 checks passed
@sanmai sanmai deleted the fix/gitignore branch May 31, 2025 09:37
@GrahamCampbell
Copy link

This change is wrong. You have now ignored the git ignore file and git attributes files.

GrahamCampbell added a commit to GrahamCampbell/php-liquid that referenced this pull request May 31, 2025
@sanmai
Copy link
Collaborator Author

sanmai commented May 31, 2025

$ git ls-files .gitignore .gitattributes 
.gitattributes
.gitignore

It sounds like they are still there.

@GrahamCampbell
Copy link

That's not what ignore means. It means ignore changes. Not delete from the repo.

@sanmai
Copy link
Collaborator Author

sanmai commented Jun 1, 2025

I can see that git add -p still considers changes to these files. I don't think you understand how .gitignore works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants