Skip to content

Conversation

@laxmareddyp
Copy link
Collaborator

@laxmareddyp laxmareddyp commented Nov 14, 2025

Description of the change

Reference

Colab Notebook

Checklist

  • I have added all the necessary unit tests for my change.
  • I have verified that my change does not break existing code and works with all backends (TensorFlow, JAX, and PyTorch).
  • My PR is based on the latest changes of the main branch (if unsure, rebase the code).
  • I have followed the Keras Hub Model contribution guidelines in making these changes.
  • I have followed the Keras Hub API design guidelines in making these changes.
  • I have signed the Contributor License Agreement.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @laxmareddyp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates new Qwen3 text embedding model presets into Keras Hub. This expansion provides users with access to different scales of Qwen3 embedding models, each offering varying parameter counts and flexible embedding dimensions, thereby enhancing the platform's capabilities for diverse natural language processing tasks.

Highlights

  • New Qwen3 Embedding Presets: Three new Qwen3 text embedding model presets have been added: qwen3_embedding_0.6b_en, qwen3_embedding_4b_en, and qwen3_embedding_8b_en.
  • Model Specifications: These models feature a 32k context length and offer flexible, user-defined embedding dimensions, ranging from 32 to 1024 for the 0.6B model, 32 to 2560 for the 4B model, and 32 to 4096 for the 8B model.
  • Parameter Counts: The added models have parameter counts of approximately 0.6 billion, 4 billion, and 8 billion respectively, providing a range of options for different use cases.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds three new presets for Qwen3 embedding models to qwen3_presets.py. While the structure of the new presets is consistent with existing ones in the file, the pull request is missing corresponding unit tests to validate that these new presets can be loaded and function correctly. The contribution guidelines for this repository state that testing is a mandatory part of any change. I have added a comment with a suggestion on how to add a test for the new presets.

Copy link
Collaborator

@sachinprasadhs sachinprasadhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the conversion script as well, to review the changes made in conversion script to include these changes.

@laxmareddyp
Copy link
Collaborator Author

Update the conversion script as well, to review the changes made in conversion script to include these changes.

Will raise a Seperate PR for the same. Please merge this.

@divyashreepathihalli divyashreepathihalli merged commit 932e98a into keras-team:master Nov 24, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants