Code janitoring #416
Closed
Code janitoring #416
+503
−392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few of them, do not know which one it is, do not care to spend more time figuring out exactly which one it is, since this stole over an hour of my life.
This prevents inconsistencies, like only having an MSRV on one of the packages.
trybuild is VERY SLOW and it hides the test content from tooling (clippy, fmt, rust-analyzer, etc.). These tests must compile and pass so there is no reason to run them through trybuild. This change reduces test run time from 8.7s seconds to 0.7s. The recent-rustc tests are still run through trybuild even though they do not need to be simply because this avoids adding a build.rs and build dependency for versioning. Once the MSRV is increased this can also just go away.
Owner
|
Merged most of this as 8367f69...830ba4f, but decided to use prettyplease instead of the double rustfmt for better formatting of the deeply nested generated code, and just went ahead and bumped the MSRV to 1.82 now that it's a year old instead of needing to continue splitting that test out. Thanks! |
Contributor
Author
|
Sounds good, thanks! I hope to return to the other PR to make the required changes as soon as I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set includes just basic maintenance stuff, no functional changes: