Use comprehensive lint command #712
Merged
+2
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed https://github.com/kubeflow/mpi-operator/blob/master/.github/workflows/golangci-lint.yml actions file so that we can comprehensive lint command across local development and CI.
The lint gh actions caused the double golangci-lint version management. After this PR, the golangci-lint version is managed in a single place.
mpi-operator/Makefile
Lines 151 to 154 in 6c4f285