Skip to content

Conversation

@tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Aug 31, 2025

I removed https://github.com/kubeflow/mpi-operator/blob/master/.github/workflows/golangci-lint.yml actions file so that we can comprehensive lint command across local development and CI.

The lint gh actions caused the double golangci-lint version management. After this PR, the golangci-lint version is managed in a single place.

@tenzen-y
Copy link
Member Author

/assign @terrytangyuan

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 7648077 into kubeflow:master Sep 2, 2025
9 checks passed
@tenzen-y tenzen-y deleted the execute-golangci-lint-as-part-of-make-target-in-ci branch September 2, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants