Skip to content

Conversation

@pschoen-itsc
Copy link
Contributor

@pschoen-itsc pschoen-itsc commented Oct 24, 2025

Description of your changes:

Checklist:

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@pschoen-itsc pschoen-itsc changed the title Add ha overlay for seaweedfs feature: add ha overlay for seaweedfs Oct 24, 2025
@juliusvonkohout
Copy link
Member

juliusvonkohout commented Oct 29, 2025

As a first feedback we need to make sure that the single pod deployment stays the default and you need to rebase (not merge) to master.

@juliusvonkohout
Copy link
Member

/ok-to-test

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Oct 29, 2025

CC @akagami-harsh for feedback

@juliusvonkohout
Copy link
Member

And please test directly with 4.0.0 as in #12406

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Nov 3, 2025

Signed-off-by: Patrick Schönthaler <[email protected]>

# Conflicts:
#	manifests/kustomize/third-party/seaweedfs/base/seaweedfs/kustomization.yaml
#	manifests/kustomize/third-party/seaweedfs/base/seaweedfs/seaweedfs-create-admin-user-job.yaml
Signed-off-by: Patrick Schönthaler <[email protected]>
Signed-off-by: Patrick Schönthaler <[email protected]>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign humairak for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pschoen-itsc
Copy link
Contributor Author

@juliusvonkohout The kind cluster for the tests is a single node cluster, right? So should I add a kind config to always create a three node cluster? Or something more complex to only do that when testing the HA setup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants