-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feature: add ha overlay for seaweedfs #12391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
manifests/kustomize/third-party/seaweedfs/base/seaweedfs/seaweedfs-create-admin-user-job.yaml
Outdated
Show resolved
Hide resolved
|
As a first feedback we need to make sure that the single pod deployment stays the default and you need to rebase (not merge) to master. |
|
/ok-to-test |
|
CC @akagami-harsh for feedback |
|
And please test directly with 4.0.0 as in #12406 |
|
https://artifacthub.io/packages/helm/bitnami/seaweedfs/4.0.0 and even more https://github.com/seaweedfs/seaweedfs/tree/master/k8s/charts/seaweedfs might be a good comparision |
db814d2 to
85fbf6b
Compare
Signed-off-by: Patrick Schönthaler <[email protected]> # Conflicts: # manifests/kustomize/third-party/seaweedfs/base/seaweedfs/kustomization.yaml # manifests/kustomize/third-party/seaweedfs/base/seaweedfs/seaweedfs-create-admin-user-job.yaml
Signed-off-by: Patrick Schönthaler <[email protected]>
85fbf6b to
87ded4e
Compare
Signed-off-by: Patrick Schönthaler <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@juliusvonkohout The kind cluster for the tests is a single node cluster, right? So should I add a kind config to always create a three node cluster? Or something more complex to only do that when testing the HA setup? |
Description of your changes:
Checklist: