-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🐛 E2E: Propagate clusterctl variables for cluster upgrades #12949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🐛 E2E: Propagate clusterctl variables for cluster upgrades #12949
Conversation
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @vknabel. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@vknabel Thx! Please take a look at #12949 (comment) |
|
@sbueringer thx for having a look. |
|
/ok-to-test |
What this PR does / why we need it:
We'd like to implement E2E tests for our infrastructure provider. In this case using
ClusterUpgradeConformanceSpec.Though in our case the Control Plane IP address is being created from within our testing suite in Go code and therefore cannot be passed to the tests using the
E2EConfigor environment variables. Instead we load the config and patch the variables in-memory. Then we callClusterUpgradeConformanceSpec. Though theclusterctl.ApplyClusterTemplateAndWaitcurrently does not respect these variables and always derives them from the config file itself.Passing the variables to the clusterctl apply would solve this issue.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area e2e-testing