Skip to content

Conversation

@vknabel
Copy link

@vknabel vknabel commented Nov 4, 2025

What this PR does / why we need it:
We'd like to implement E2E tests for our infrastructure provider. In this case using ClusterUpgradeConformanceSpec.

Though in our case the Control Plane IP address is being created from within our testing suite in Go code and therefore cannot be passed to the tests using the E2EConfig or environment variables. Instead we load the config and patch the variables in-memory. Then we call ClusterUpgradeConformanceSpec. Though the clusterctl.ApplyClusterTemplateAndWait currently does not respect these variables and always derives them from the config file itself.

Passing the variables to the clusterctl apply would solve this issue.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area e2e-testing

@k8s-ci-robot k8s-ci-robot added the area/e2e-testing Issues or PRs related to e2e testing label Nov 4, 2025
@linux-foundation-easycla
Copy link

CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chrischdi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 4, 2025
@k8s-ci-robot k8s-ci-robot requested a review from elmiko November 4, 2025 12:18
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 4, 2025
@k8s-ci-robot k8s-ci-robot requested a review from sivchari November 4, 2025 12:18
@k8s-ci-robot
Copy link
Contributor

Hi @vknabel. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member

@vknabel Thx! Please take a look at #12949 (comment)

@vknabel
Copy link
Author

vknabel commented Nov 7, 2025

@sbueringer thx for having a look.
The CLA agreement is in internal progress at my company. It should be signed on monday.

@sbueringer
Copy link
Member

/ok-to-test
/test pull-cluster-api-e2e-main-gke

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/e2e-testing Issues or PRs related to e2e testing cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants