-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🐛 Stop writing zero values for spec.controlPlaneEndpoint to ControlPlane objects #12958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Stop writing zero values for spec.controlPlaneEndpoint to ControlPlane objects #12958
Conversation
|
/assign @sbueringer |
|
Thank you! /test pull-cluster-api-e2e-main-gke |
|
LGTM label has been added. Git tree hash: 51a8271791bf96cac0b626cacc62fdb741349859
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-1.10 release-1.11 |
|
@faiq: new pull request created: #12981 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.11 |
|
You'll have to open a manual cherry-pick PR for release-1.10 |
|
@sbueringer: new pull request created: #12982 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
If spec.ControlPlaneEndpoint is set on the control plane object we should ignore that when merging the objects together. We follow a similar pattern for infrastructureCluster objects.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area clusterclass