🌱 Add some more tests to the priorityqueue #3387
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/cc @sbueringer |
alvaroaleman
changed the title
This change adds a few additional tests to the priorityqueue as well as extends an existing one to test a few more things. All of these already pass.
| Expect(priority).To(Equal(1)) | ||
| Expect(q.Len()).To(Equal(0)) | ||
|
|
||
| metrics.mu.Lock() |
There was a problem hiding this comment.
Looks like unlock is missing
There was a problem hiding this comment.
Yeah, the test ends after checking on the metrics, so there is no need to unlock, it will gets gced there anyways
There was a problem hiding this comment.
Yup, got that. Just seems cleaner to unlock and not leave that locked
|
/lgtm /hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: da7942db793eb6ff8b9ad9ef2fc0a4aff49c509e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
3 participants
This change adds a few additional tests to the priorityqueue as well as extends an existing one to test a few more things. All of these already pass.