🐛 (go/v4;deploy-image/v1-alpha): Remove omitempty from nested struct JSON tags in API scaffolds #5212
+84
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
k8s-ci-robot
added
the
size/L
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
fix-api-linter
branch
2 times, most recently
from
54c5cdb to
05c6b81
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
Remove omitempty from JSON tags on nested struct fields such as metav1 ObjectMeta Status and metav1 ListMeta in API type scaffolds The omitempty tag has no effect on nested structs in Go and triggers linter warnings For Go version 1.24+ and later omitzero correctly handles nested structs and omits them when empty making omitempty redundant and misleading The optional markers already indicate optional fields for CRD schema generation Updated JSON tags: - metav1 ObjectMeta metadata omitempty omitzero becomes metadata omitzero - Status fields status omitempty omitzero becomes status omitzero - metav1 ListMeta metadata omitempty becomes metadata omitzero This resolves linter warnings from gopls modernize analyzer and kube api linter while maintaining correct behavior for projects using Go 1.24+ Signed-off-by: Camila Macedo <[email protected]>
camilamacedo86
force-pushed
the
fix-api-linter
branch
from
05c6b81 to
1502aaa
Compare
Member
Author
|
Could you please give a hand on the review? |
afzal442
approved these changes
Nov 15, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afzal442, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove 'omitempty' from JSON tags on nested struct fields (metav1.ObjectMeta, Status, and metav1.ListMeta) in API type scaffolds. The 'omitempty' tag has no effect on nested structs in Go and triggers linter warnings.
For Go 1.24+, 'omitzero' correctly handles nested structs and omits them when empty, making 'omitempty' redundant and misleading. The '// +optional' markers already indicate optional fields for CRD schema generation.
Updated JSON tags:
This resolves linter warnings from gopls modernise analyser and kube-api-linter while maintaining correct behaviour for projects using Go 1.24+.
Closes #5205