-
Notifications
You must be signed in to change notification settings - Fork 1.6k
✨ (helm/v2-alpha) add tolerations, nodeselector and affinity #5247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -188,6 +188,35 @@ controllerManager: | |
| cpu: 10m | ||
| memory: 64Mi | ||
|
|
||
| # Manager pod's affinity | ||
| affinity: | ||
| nodeAffinity: | ||
| requiredDuringSchedulingIgnoredDuringExecution: | ||
| nodeSelectorTerms: | ||
| - matchExpressions: | ||
| - key: kubernetes.io/arch | ||
| operator: In | ||
| values: | ||
| - amd64 | ||
| - arm64 | ||
| - ppc64le | ||
| - s390x | ||
| - key: kubernetes.io/os | ||
| operator: In | ||
| values: | ||
| - linux | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This must be defined by who maintain the project and not who consume the project We should only expose values in the HelmCharts that make sense for who consume the solution.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm confused. You asked in a previous comment to put an example in the doc. Now, I should remove it ?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not about the example or the docs. This configuration should not be exposed to end users. It is the responsibility of the project maintainers to define it in the config/manager (Kustomize). Only values that users can safely change should be exposed in Helm Supported architectures should be configured in Kustomize and propagated into the Helm charts, but not exposed as user-configurable values. Allowing users to change these settings can result in broken deployments when the image or project does not actually support them.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where is this PR defining supported architecture ? |
||
|
|
||
| # Manager pod's node selector | ||
| nodeSelector: | ||
| kubernetes.io/os: linux | ||
|
|
||
| # Manager pod's tolerations | ||
| tolerations: | ||
| - key: "node.kubernetes.io/unreachable" | ||
| operator: "Exists" | ||
| effect: "NoExecute" | ||
| tolerationSeconds: 6000 | ||
|
|
||
| # Essential RBAC permissions (required for controller operation) | ||
| # These include ServiceAccount, controller permissions, leader election, and metrics access | ||
| # Note: Essential RBAC is always enabled as it's required for the controller to function | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.