Skip to content

FlavorFungability: replace FlavorFungibilityImplicitPreferenceDefault feature gate with API #7316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

FlavorFungability: replace FlavorFungibilityImplicitPreferenceDefault feature gate with API #7316

wants to merge 1 commit into from
+379 −102

Conversation

@vladikkuzn
Copy link
Contributor

@vladikkuzn vladikkuzn commented Oct 17, 2025 •
edited
Loading

What type of PR is this?

/kind api-change

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #6184

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 17, 2025
@netlify
Copy link

netlify bot commented Oct 17, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 92c279b
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6904f2af8b6b4900080f184f
😎 Deploy Preview https://deploy-preview-7316--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vladikkuzn
Once this PR has been reviewed and has the lgtm label, please assign gabesaba for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 17, 2025
@vladikkuzn vladikkuzn changed the title [KEP] FlavorFungability: replace FlavorFungibilityImplicitPreferenceDefault feature gate with API FlavorFungability: replace FlavorFungibilityImplicitPreferenceDefault feature gate with API Oct 17, 2025
@vladikkuzn
Copy link
Contributor Author

/assign

mimowo
mimowo reviewed Oct 20, 2025
View reviewed changes
pkg/scheduler/flavorassigner/flavorassigner.go
return true
}

if !features.Enabled(features.FlavorFungibilityImplicitPreferenceDefault) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
We cannot just remove the feature gate. We need to introduce API instead which will be able to express the preferences.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2025
@vladikkuzn vladikkuzn force-pushed the replace-FlavorFungibilityImplicitPreferenceDefault-feature-gate-with-API branch from 4f8cb0b to 84adb94 Compare October 29, 2025 22:04
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2025
@vladikkuzn
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 29, 2025
@k8s-ci-robot
Copy link
Contributor

@vladikkuzn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-test-unit-main 84adb94 link true /test pull-kueue-test-unit-main
pull-kueue-verify-main 84adb94 link true /test pull-kueue-verify-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vladikkuzn vladikkuzn force-pushed the replace-FlavorFungibilityImplicitPreferenceDefault-feature-gate-with-API branch from 84adb94 to dc9e8f1 Compare October 31, 2025 17:08
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2025
@vladikkuzn vladikkuzn force-pushed the replace-FlavorFungibilityImplicitPreferenceDefault-feature-gate-with-API branch from dc9e8f1 to e7152d4 Compare October 31, 2025 17:13
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2025
@vladikkuzn vladikkuzn force-pushed the replace-FlavorFungibilityImplicitPreferenceDefault-feature-gate-with-API branch from e7152d4 to 0744117 Compare October 31, 2025 17:21
@vladikkuzn
[KEP] FlavorFungability: replace FlavorFungibilityImplicitPreferenceD…
92c279b 
…efault feature gate with API

* preference API field
@vladikkuzn vladikkuzn force-pushed the replace-FlavorFungibilityImplicitPreferenceDefault-feature-gate-with-API branch from 0744117 to 92c279b Compare October 31, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mimowo mimowo mimowo left review comments

@kannon92 kannon92 Awaiting requested review from kannon92

@mbobrovskyi mbobrovskyi Awaiting requested review from mbobrovskyi

Assignees

@vladikkuzn vladikkuzn

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/documentation Categorizes issue or PR as related to documentation. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vladikkuzn @k8s-ci-robot @mimowo