Adding autoKueue to helm chart #7368
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,131 @@ | ||||||
| # 1. ConfigMap containing Kueue resource definitions | ||||||
| # This resource will be created in the 'kueue-system' namespace. | ||||||
| {{- if .Values.enableAutoKueue }} | ||||||
| apiVersion: v1 | ||||||
| kind: ConfigMap | ||||||
| metadata: | ||||||
| name: {{ .Release.Name }}-kueue-resources | ||||||
| namespace: kueue-system | ||||||
| annotations: | ||||||
| "helm.sh/hook": post-install,post-upgrade | ||||||
| "helm.sh/hook-weight": "-5" | ||||||
| "helm.sh/hook-delete-policy": before-hook-creation | ||||||
| data: | ||||||
| resources.yaml: |- | ||||||
| apiVersion: kueue.x-k8s.io/v1beta1 | ||||||
|
There was a problem hiding this comment.
Suggested change
nit I think it should already work and seems better to use new versions going forward. |
||||||
| kind: Topology | ||||||
| metadata: | ||||||
| name: "default" | ||||||
| spec: | ||||||
| levels: | ||||||
| {{- range .Values.autoKueue.tasLevels }} | ||||||
| - nodeLabel: {{ .name | quote }} | ||||||
| {{- end }} | ||||||
| --- | ||||||
| kind: ResourceFlavor | ||||||
| apiVersion: kueue.x-k8s.io/v1beta1 | ||||||
| metadata: | ||||||
| name: "tas-flavor" | ||||||
|
There was a problem hiding this comment.
Suggested change
since we may need other flavors for other accelerators. |
||||||
| spec: | ||||||
| {{- with .Values.autoKueue.nodeLabel }} | ||||||
| nodeLabels: | ||||||
| {{- toYaml . | nindent 8 }} | ||||||
| {{- end }} | ||||||
| topologyName: "default" | ||||||
| tolerations: | ||||||
| - key: "nvidia.com/gpu" | ||||||
| operator: "Exists" | ||||||
| effect: NoSchedule | ||||||
| --- | ||||||
| apiVersion: kueue.x-k8s.io/v1beta1 | ||||||
| kind: ClusterQueue | ||||||
| metadata: | ||||||
| name: {{ .Values.autoKueue.clusterQueueName | quote }} | ||||||
| spec: | ||||||
| namespaceSelector: {} # match all. | ||||||
| resourceGroups: | ||||||
| - coveredResources: ["nvidia.com/gpu"] | ||||||
| flavors: | ||||||
| - name: "tas-flavor" | ||||||
| resources: | ||||||
| - name: "nvidia.com/gpu" | ||||||
| nominalQuota: 100000000 | ||||||
| --- | ||||||
| # 2. Service Account for the Job | ||||||
| # This resource will be created in the 'kueue-system' namespace. | ||||||
| apiVersion: v1 | ||||||
| kind: ServiceAccount | ||||||
| metadata: | ||||||
| name: {{ .Release.Name }}-kueue-hook-sa | ||||||
| namespace: kueue-system | ||||||
| annotations: | ||||||
| "helm.sh/hook": post-install,post-upgrade | ||||||
| "helm.sh/hook-delete-policy": before-hook-creation | ||||||
|
|
||||||
| --- | ||||||
| # 3. ClusterRole with required permissions | ||||||
| # This defines permissions to get resources and create Kueue resources. | ||||||
| apiVersion: rbac.authorization.k8s.io/v1 | ||||||
| kind: ClusterRole | ||||||
| metadata: | ||||||
| name: {{ .Release.Name }}-kueue-hook-clusterrole | ||||||
|
There was a problem hiding this comment.
Suggested change
wdyt? |
||||||
| annotations: | ||||||
| "helm.sh/hook": post-install,post-upgrade | ||||||
| "helm.sh/hook-delete-policy": before-hook-creation | ||||||
| rules: | ||||||
| - apiGroups: ["kueue.x-k8s.io"] | ||||||
| resources: ["topologies", "resourceflavors", "clusterqueues", "localqueues"] | ||||||
| verbs: ["create", "get", "list", "patch", "update"] | ||||||
| - apiGroups: [""] # Core API group | ||||||
| resources: ["configmaps", "endpoints"] | ||||||
| verbs: ["get"] | ||||||
|
|
||||||
| --- | ||||||
| # 4. A ClusterRoleBinding to grant the permissions cluster-wide | ||||||
| # This is required for managing cluster-scoped resources like Topologies. | ||||||
| apiVersion: rbac.authorization.k8s.io/v1 | ||||||
| kind: ClusterRoleBinding | ||||||
| metadata: | ||||||
| name: {{ .Release.Name }}-kueue-hook-crb | ||||||
|
There was a problem hiding this comment.
Suggested change
And the name for the role I would say |
||||||
| annotations: | ||||||
| "helm.sh/hook": post-install,post-upgrade | ||||||
| "helm.sh/hook-delete-policy": before-hook-creation | ||||||
| roleRef: | ||||||
| apiGroup: rbac.authorization.k8s.io | ||||||
| kind: ClusterRole | ||||||
| name: {{ .Release.Name }}-kueue-hook-clusterrole | ||||||
| subjects: | ||||||
| - kind: ServiceAccount | ||||||
| name: {{ .Release.Name }}-kueue-hook-sa | ||||||
| namespace: kueue-system # The namespace where the ServiceAccount lives | ||||||
| --- | ||||||
| # 5. The Job that waits and applies the resources | ||||||
| # This Job will be created and run in the 'kueue-system' namespace. | ||||||
| apiVersion: batch/v1 | ||||||
| kind: Job | ||||||
| metadata: | ||||||
| name: "{{ .Release.Name }}-create-kueue-resources-job" | ||||||
| namespace: kueue-system | ||||||
| annotations: | ||||||
| "helm.sh/hook": post-install,post-upgrade | ||||||
| "helm.sh/hook-weight": "5" | ||||||
| "helm.sh/hook-delete-policy": hook-succeeded,before-hook-creation | ||||||
| spec: | ||||||
| template: | ||||||
| spec: | ||||||
| serviceAccountName: {{ .Release.Name }}-kueue-hook-sa | ||||||
| containers: | ||||||
| - name: kubectl-apply | ||||||
| image: bitnami/kubectl:latest | ||||||
|
There was a problem hiding this comment. Can we use some image that is hosted by k8s registry? Please explore https://explore.ggcr.dev/?repo=registry.k8s.io there is |
||||||
| command: | ||||||
| - /bin/sh | ||||||
| - -c | ||||||
| - | | ||||||
| set -ex | ||||||
| kubectl get configmap {{ .Release.Name }}-kueue-resources -n kueue-system -o=jsonpath='{.data.resources\.yaml}' | kubectl apply -f - | ||||||
| echo "🚀 All Kueue resources applied successfully." | ||||||
| restartPolicy: Never | ||||||
| backoffLimit: 5 | ||||||
| {{- end }} | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wdyt?