Skip to content

Conversation

@mbobrovskyi
Copy link
Contributor

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Graduate the visibility API to v1beta2.

Which issue(s) this PR fixes:

Fixes #7374

Special notes for your reviewer:

Does this PR introduce a user-facing change?

v1beta2: graduate the visibility API

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Oct 27, 2025
@netlify
Copy link

netlify bot commented Oct 27, 2025

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit b35c7bb
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6903faaa1e7fc30008fc0ce4
😎 Deploy Preview https://deploy-preview-7411--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 27, 2025
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 27, 2025
@mbobrovskyi mbobrovskyi force-pushed the feature/bump-visibility-version branch 2 times, most recently from 32ffa21 to 742d8b6 Compare October 27, 2025 15:49
@mimowo
Copy link
Contributor

mimowo commented Oct 27, 2025

please make sure there is at least one test using. old api

@mbobrovskyi mbobrovskyi force-pushed the feature/bump-visibility-version branch 5 times, most recently from 289ae50 to 588cc70 Compare October 30, 2025 05:06
@mbobrovskyi mbobrovskyi changed the title [WIP] v1beta2: graduate the visibility API. v1beta2: graduate the visibility API. Oct 30, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2025
@mbobrovskyi
Copy link
Contributor Author

/cc @mimowo

@mbobrovskyi mbobrovskyi force-pushed the feature/bump-visibility-version branch 2 times, most recently from 4837875 to b242513 Compare October 30, 2025 05:12
@mbobrovskyi
Copy link
Contributor Author

/retest

Known issue #7390.

@mbobrovskyi mbobrovskyi force-pushed the feature/bump-visibility-version branch 2 times, most recently from 0a3faf5 to ba98448 Compare October 30, 2025 11:41
@mbobrovskyi mbobrovskyi requested a review from mimowo October 30, 2025 11:41
@mimowo
Copy link
Contributor

mimowo commented Oct 30, 2025

/lgtm
/approve
thank you for that! Seems like this completes the main migration. We will have to add a couple of conversions

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2e38f7890a8d10890b02012824ad35a9be6f82b1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2025
@mimowo
Copy link
Contributor

mimowo commented Oct 30, 2025

This requires rebase @mbobrovskyi

@mbobrovskyi mbobrovskyi force-pushed the feature/bump-visibility-version branch from ba98448 to b35c7bb Compare October 30, 2025 23:54
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2025
@mbobrovskyi
Copy link
Contributor Author

This requires rebase @mbobrovskyi

Done

@mimowo
Copy link
Contributor

mimowo commented Oct 31, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 904e363e2e45c312ea3c6a0e55e3a9139721b91f

@mimowo
Copy link
Contributor

mimowo commented Oct 31, 2025

/test pull-kueue-test-integration-multikueue-main
flake: #7462

@k8s-ci-robot k8s-ci-robot merged commit d95f2ea into kubernetes-sigs:main Oct 31, 2025
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.15 milestone Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1beta2: graduate the visibility API

4 participants