-
Notifications
You must be signed in to change notification settings - Fork 480
add kep for clusterqueue exclude resource prefixes at ClusterQueue level #7415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add kep for clusterqueue exclude resource prefixes at ClusterQueue level #7415
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kannon92 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
||
| ### User Stories (Optional) | ||
|
|
||
| #### Story 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Story 1, I guess... if you're allowing exclusions on the CQ level, let's take GPU as an example, where some CQs exclude GPU and some CQs don't.
You have multiple entry points to schedule GPUs. So the world view of the available nominalQuota in a Cohort doesn't necessarily match the underlying k8s cluster.
As in, the CQs that exclude GPUs can still schedule GPU workloads, thus taking up the underlying GPU in the cluster. But Kueue isn't tracking that. And then when other CQs try to claim that quota, its not actually there available to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea good point. Talking with you offline I think maybe an allow list of resources may be a better choice than adding this at CQ.
This would put more work on a cluster admin actually and could potentially lead to people skipping kueue resourcing.
|
/close |
|
@kannon92: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Draft a KEP for ExcludeResources at the ClusterQueue level
Which issue(s) this PR fixes:
KEP for #5800
Special notes for your reviewer:
Does this PR introduce a user-facing change?